add 'dominh set' and 'dominh info' to CLI#25
Draft
pdragy wants to merge 4 commits intogavanderhoorn:masterfrom
Draft
add 'dominh set' and 'dominh info' to CLI#25pdragy wants to merge 4 commits intogavanderhoorn:masterfrom
pdragy wants to merge 4 commits intogavanderhoorn:masterfrom
Conversation
pdragy
commented
Jun 4, 2025
pdragy
commented
Jun 4, 2025
|
|
||
| numregs = ', '.join([str(c.numreg(i + 1).val) for i in range(5)]) | ||
|
|
||
| if (not args['--short']): |
Author
There was a problem hiding this comment.
nit: can we combine this and make 1 block for the '--short' flag?
Author
There was a problem hiding this comment.
probably yes, hesitant to do this without access to hardware or roboguide for testing
pdragy
commented
Jun 4, 2025
pdragy
commented
Jun 4, 2025
pdragy
commented
Jun 6, 2025
Owner
|
Hi, thanks for the PR, really appreciated. I'm going to need a little more time before I can review it. Just thought I'd let you know. |
Author
|
No problem, gives me time to re-work the commits and fix the bug, and maybe test again. I can un-draft the PR when it's ready. |
This updates the python versions in the github action. Fixes: "Version 3.8 with arch x64 not found Available versions: 3.10.18 (x64) 3.11.13 (x64) 3.12.11 (x64) 3.13.4 (x64) 3.9.23 (x64)"
Fixes the lint issue: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the dominh CLI with 'set' and 'info' commands. 'set' may require controller to be in controlled start for some variables.
Examples
Other Notes:
examples/print_controller_info.py. I added an optional--shortflag. I also changed some of the terminal output to be fixed-width and padded, for better behaviour when chaining with other CLI commands likewatch.infoduring controlled start produces an exception. This should probably be fixed, or at least the exception should be handled and produce more useful output for the user if it is the expected behavior. I believe it is an issue which existed before this commit, maybe even in the karel code. I think that runningexamples/print_controller_info.pyin controlled start will also produce the same exception, though I am unable to test this now as I don't have access to a FANUC.