Skip to content

fix(mpc): return error instead of panic when publicKey is nil in BroadcastPublicKey #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(mpc): return error instead of panic when publicKey is nil in BroadcastPublicKey #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/mpc/key_exchange_session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,13 @@ func (s *ecdhSession) Close() error {
}

func (e *ecdhSession) BroadcastPublicKey() error {
// Peer restart mid-handshake can schedule this broadcast goroutine
// before the local publicKey is populated; crypto/ecdh.(*PublicKey).Bytes
// then panics with nil pointer dereference. Return an error so the
// caller's retrigger logic takes over instead of the goroutine dying.
if e == nil || e.publicKey == nil {
return fmt.Errorf("ecdh session %s has no public key to broadcast yet", e.nodeID)
}
publicKeyBytes := e.publicKey.Bytes()
msg := types.ECDHMessage{
From: e.nodeID,
Expand Down