[FA-11] Adding endpoint for challenging real person#9
Merged
scott-clare1 merged 13 commits intomainfrom Apr 3, 2025
Merged
Conversation
samgwd
reviewed
Apr 3, 2025
samgwd
reviewed
Apr 3, 2025
samgwd
reviewed
Apr 3, 2025
samgwd
reviewed
Apr 3, 2025
Collaborator
samgwd
left a comment
There was a problem hiding this comment.
Given we will be open sourcing this, lets try get into a good habit for PR summaries. Can you make sure we've been through the checklist and ticked the boxes. One thing I've used before in PR summaries is a template of 'What', 'Why', 'How', 'Extra'. Each as titles. Let me know what you think for this.
samgwd
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an endpoint for creating a game against a real user and checking whether it is the agents turn or not
I have also added an
exceptionsmodule for informative exceptions for the agent.Checklist
Please ensure you have done the following:
Type of change
Tick all those that apply:
MacOS tests
To trigger the CI to run on a macOS backed workflow, add the
macos-ci-testlabel to the pull request (PR).Our advice is to only run this workflow when testing the compatability between operating systems for a change that you've made, e.g., adding a new dependency to the virtual environment.