Skip to content

[FA-11] Adding endpoint for challenging real person#9

Merged
scott-clare1 merged 13 commits intomainfrom
FA-11-adding-endpoint-for-challenging-real-person
Apr 3, 2025
Merged

[FA-11] Adding endpoint for challenging real person#9
scott-clare1 merged 13 commits intomainfrom
FA-11-adding-endpoint-for-challenging-real-person

Conversation

@scott-clare1
Copy link
Contributor

@scott-clare1 scott-clare1 commented Apr 2, 2025

This PR adds an endpoint for creating a game against a real user and checking whether it is the agents turn or not

I have also added an exceptions module for informative exceptions for the agent.

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

MacOS tests

To trigger the CI to run on a macOS backed workflow, add the macos-ci-test label to the pull request (PR).

Our advice is to only run this workflow when testing the compatability between operating systems for a change that you've made, e.g., adding a new dependency to the virtual environment.

Note: This can take up to 5 minutes to run. This workflow costs x10 more than a Linux-based workflow, use at discretion.

@scott-clare1 scott-clare1 self-assigned this Apr 2, 2025
@scott-clare1 scott-clare1 added the enhancement New feature or request label Apr 2, 2025
@scott-clare1 scott-clare1 marked this pull request as ready for review April 3, 2025 09:41
Copy link
Collaborator

@samgwd samgwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we will be open sourcing this, lets try get into a good habit for PR summaries. Can you make sure we've been through the checklist and ticked the boxes. One thing I've used before in PR summaries is a template of 'What', 'Why', 'How', 'Extra'. Each as titles. Let me know what you think for this.

@scott-clare1 scott-clare1 requested a review from samgwd April 3, 2025 10:35
@scott-clare1 scott-clare1 merged commit d066c70 into main Apr 3, 2025
1 check passed
@scott-clare1 scott-clare1 deleted the FA-11-adding-endpoint-for-challenging-real-person branch April 4, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants