Merged
Conversation
samgwd
reviewed
Apr 4, 2025
YazIbrahim
approved these changes
Apr 4, 2025
YazIbrahim
left a comment
There was a problem hiding this comment.
Nothing to add on the code beyond Sam's comment.
What are your thoughts, on adding something like "Have ran application tests" to the PR checklist.
Contributor
Author
Yeah I like that will add in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds application tests for the server and logs to server endpoints.
This application tests should catch any breaking changes to the server and should be run my a developer.
These cannot be run as part of pre-commit unless we add a secret with the API key to GH.
Checklist
Please ensure you have done the following:
Type of change
Tick all those that apply:
MacOS tests
To trigger the CI to run on a macOS backed workflow, add the
macos-ci-testlabel to the pull request (PR).Our advice is to only run this workflow when testing the compatability between operating systems for a change that you've made, e.g., adding a new dependency to the virtual environment.