Skip to content

[FA-21] Adding application tests#15

Merged
scott-clare1 merged 7 commits intomainfrom
FA-21-application-tests
Apr 4, 2025
Merged

[FA-21] Adding application tests#15
scott-clare1 merged 7 commits intomainfrom
FA-21-application-tests

Conversation

@scott-clare1
Copy link
Contributor

@scott-clare1 scott-clare1 commented Apr 4, 2025

This PR adds application tests for the server and logs to server endpoints.

This application tests should catch any breaking changes to the server and should be run my a developer.

These cannot be run as part of pre-commit unless we add a secret with the API key to GH.

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

MacOS tests

To trigger the CI to run on a macOS backed workflow, add the macos-ci-test label to the pull request (PR).

Our advice is to only run this workflow when testing the compatability between operating systems for a change that you've made, e.g., adding a new dependency to the virtual environment.

Note: This can take up to 5 minutes to run. This workflow costs x10 more than a Linux-based workflow, use at discretion.

@scott-clare1 scott-clare1 self-assigned this Apr 4, 2025
@scott-clare1 scott-clare1 added the enhancement New feature or request label Apr 4, 2025
@scott-clare1 scott-clare1 marked this pull request as ready for review April 4, 2025 13:27
Copy link

@YazIbrahim YazIbrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add on the code beyond Sam's comment.

What are your thoughts, on adding something like "Have ran application tests" to the PR checklist.

@scott-clare1
Copy link
Contributor Author

Nothing to add on the code beyond Sam's comment.

What are your thoughts, on adding something like "Have ran application tests" to the PR checklist.

Yeah I like that will add in

@scott-clare1 scott-clare1 merged commit 6dca15c into main Apr 4, 2025
1 check passed
@scott-clare1 scott-clare1 deleted the FA-21-application-tests branch April 4, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants