Added Page.close to the Page API.#52
Open
CPeluti wants to merge 1 commit into
Open
Conversation
ftes
reviewed
May 19, 2026
| config :playwright_ex, | ||
| executable: "assets/node_modules/playwright/cli.js", | ||
| timeout: String.to_integer(System.get_env("PW_TIMEOUT", "1000")), | ||
| timeout: String.to_integer(System.get_env("PW_TIMEOUT", "10000")), |
Owner
There was a problem hiding this comment.
Suggested change
| timeout: String.to_integer(System.get_env("PW_TIMEOUT", "10000")), | |
| timeout: String.to_integer(System.get_env("PW_TIMEOUT", "1000")), |
Any particular reason for this change?
Even with small free Github Actions runners, 1s seems to be sufficient.
Author
There was a problem hiding this comment.
Yes, for some reason on both my machines (Linux and Mac) all the tests were failing due to timeout. I think it's related to the startup of the playwright. Once I've tuned the timeout up everything run fine.
ftes
reviewed
May 19, 2026
Owner
ftes
left a comment
ftes
left a comment
There was a problem hiding this comment.
Thanks. Could you move the nix/flake changes to a separate PR please?
Author
Sure. |
CPeluti
force-pushed
the
feature/issue-50
branch
2 times, most recently
from
d5f8c39 to
3581b41
Compare
Author
|
I've updated the commit removing the flake and also removed the change to the timeout. |
CPeluti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fulfills #50 adding the Page.close to the Page API.
Also the PR adds the flake.nix for nix users.