Add class attribute protocol to HTTPFileSystem#1935
Merged
martindurant merged 4 commits intofsspec:masterfrom Oct 28, 2025
Merged
Add class attribute protocol to HTTPFileSystem#1935martindurant merged 4 commits intofsspec:masterfrom
martindurant merged 4 commits intofsspec:masterfrom
Conversation
Member
martindurant
left a comment
There was a problem hiding this comment.
Yes, this is the right fix.
For the test, I think a subprocess should be avoided - why can't the same code be run inside the session as normal?
Member
|
Note that the downstream error is new and unrelated. |
Member
|
I simplified the test - this is equivalent? |
Contributor
Author
|
Hi @martindurant, I used subprocess before to be able to create a failing test before the patch is applied. But your version is equivalent after the patch and ensures that the first (?default) protocol on the class will be 'http'. Thanks! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1934
Currently the protocol class attribute on the HTTPFileSystem depends on the first used http protocol, due to:
filesystem_spec/fsspec/registry.py
Lines 265 to 266 in 43e60fa
This PR adds a protocol classvar tuple to the filesystem class with http and https.