Conversation
Root cause: IParquetRowGroupWriter was bound with 'let rg' instead of
'use rg', so Dispose() was never called and the row group was never
committed to the Parquet stream. The schema (column names/types) was
written, but all row data was silently discarded.
Fix: change 'let rg = writer.CreateRowGroup()' to
'use rg = writer.CreateRowGroup()' in both writeParquet and
writeParquetStream.
Also:
- Add 3 real-world PyArrow-generated sample parquet files:
weather.parquet (meteorological readings, 8 rows x 7 cols,
float32/64/int32/bool/string/DateTime, 2 null cols)
trades.parquet (financial trade records, 20 rows x 7 cols,
int16/int32/int64/float64/bool/string/DateTime)
sensors.parquet (IoT sensor log, 10 rows x 7 cols,
float32/64/int32/int64/bool/string, all with nulls)
- Add 20 new tests for the three new sample files (column shape, value
correctness, missing-value counts, and round-trip for each file)
Closes #712
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated PR from Repo Assist.
Closes #712
Root Cause
Frame.writeParquetandFrame.writeParquetStreamwere silently writing empty files — only the column schema was persisted, but all row data was discarded.The bug is a one-character fix in
src/Deedle.Parquet/Parquet.fs:All 55 tests pass (35 pre-existing + 20 new).