Skip to content

Set "--no-eff-email" flag#22

Open
archfan wants to merge 1 commit intofreeipa:masterfrom
archfan:master
Open

Set "--no-eff-email" flag#22
archfan wants to merge 1 commit intofreeipa:masterfrom
archfan:master

Conversation

@archfan
Copy link

@archfan archfan commented Jul 10, 2020

Eases automation with Ansible.

Eases automation with Ansible. We don't intend to share our Email with the EFF anyway
Copy link
Contributor

@thinkmassive thinkmassive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@rcritten
Copy link
Contributor

For this to be merged there needs to be a proper commit message describing what the change does (why is basically covered) ala https://www.freeipa.org/page/Contribute/Code#Commit_message_requirements . A ticket is not needed for this change.

Plus a sign-off needs to be added to the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants