Improve our security scan actions - #1520
Open
apyrgio wants to merge 2 commits into
Open
Conversation
The `scan.yml` and `scan_released.yml` actions share some common logic. Factor it out into separate actions, and provide the variables via inputs. Moreover, change a bit the scanning logic so that we scan only once, instead of scanning twice (once without failures and then with failures).
Every two weeks, specifically on the 5th and 20th of each month, set the severity cutoff to High, instead of critical. We use the 5th and 20th of each month for two reasons: 1. The cron syntax does not have a way to express a "biweekly" cadence. 2. The start and end of a month tend to be "busy" times, so we skew the frequency a few days later. Closes #1395
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
scan.ymlandscan_released.ymlactions share some common logic. Factor it out into separate actions, and provide the variables via inputs.Moreover:
Closes #1395
(Note, this PR is repurposed from #1438, to decouple it from the changes required for the
SECURITY.mdfile)