Add support for register-map caching #82
Open
kevynb wants to merge 2 commits intofredericvl:masterfrom
Open
Conversation
…normalization fixes, single-map fallback, and tests
Author
|
Re-reviewing the code, I realise that I could have extracted the cache functions into another class. I'll probably do that to keep things more manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#81 must be reviewed and merged first as it builds on top of it.
This PR introduces a cache for register map. These registers are not changing so a cache makes sense to avoid requesting this big object often. In the context of cloud it's not super useful but if one wants to use a local only api, then it could be super useful 😉
I added tests to support this feature.
I'm storing the security code of the device as well. I'm open to not doing it or to store it differently. Eventually it will have to be stored somehwere even if clients pass it to the lib so I settled on this for now.