Skip to content

Modernize build#19

Merged
pbrisbin merged 4 commits intomainfrom
pb/next
Jul 18, 2025
Merged

Modernize build#19
pbrisbin merged 4 commits intomainfrom
pb/next

Conversation

@pbrisbin
Copy link
Copy Markdown
Member

@pbrisbin pbrisbin commented Jul 18, 2025

Don't commit stack.yaml.lock files

These are important for reproducible builds, but Haskell libraries are
source-distributed and built on install, so they have no effect there.

They also bring a minor downside when using a tool like stack-all.

Refactor stack resolver files

  • Name them stack-ltsX, so we don't need to maintain minor changes
  • Add lts23 and lts24 files
  • Maintain stack.yaml as a symlink to latest resolver

Don't run CI on pushes to main

This CI doesn't produce or block anything useful, so it's just a waste
of build minutes.

Modernize CI

  • Use stack-action/generate (no need for separate nightly)
  • Use newer stack-action with caching built-in
  • Use haskell-actions

pbrisbin added 4 commits July 18, 2025 09:36
These are important for reproducible builds, but Haskell libraries are
source-distributed and built on install, so they have no effect there.

They also bring a minor downside when using a tool like stack-all.
- Name them `stack-ltsX`, so we don't need to maintain minor changes
- Add `lts23` and `lts24` files
- Maintain `stack.yaml` as a symlink to latest resolver
This CI doesn't produce or block anything useful, so it's just a waste
of build minutes.
- Use `stack-action/generate` (no need for separate `nightly`)
- Use newer `stack-action` with caching built-in
- Use `haskell-actions`
@pbrisbin pbrisbin changed the title pb/next Modernize build Jul 18, 2025
@pbrisbin
Copy link
Copy Markdown
Member Author

See https://github.com/freckle/github-vending-machine/pull/161 for the corresponding branch protection requirements change.

@pbrisbin pbrisbin requested a review from chris-martin July 18, 2025 14:25
@pbrisbin pbrisbin marked this pull request as ready for review July 18, 2025 14:25
@pbrisbin pbrisbin requested a review from a team as a code owner July 18, 2025 14:25
@chris-martin
Copy link
Copy Markdown
Contributor

Going to update the release step too?

      - if: steps.tag.outputs.tag
        run: stack upload --pvp-bounds lower .
        env:
          HACKAGE_KEY: ${{ secrets.HACKAGE_UPLOAD_API_KEY }}
          STACK_YAML: stack-lts12.yaml

@pbrisbin
Copy link
Copy Markdown
Member Author

I always forget that!

@pbrisbin
Copy link
Copy Markdown
Member Author

pbrisbin commented Jul 18, 2025

Oh, I don't have to. This repository uses our older stack-upload-action. Now that stack upload supports API keys, we don't really need that action anymore but one thing it is currently doing is automatically selecting the minimum resolver file. So, until I update this to move away from that (and to semantic release), this'll just work.

@pbrisbin pbrisbin merged commit 13b135e into main Jul 18, 2025
15 checks passed
@pbrisbin pbrisbin deleted the pb/next branch July 18, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants