Skip to content

bench new-app: add CLI options for non-interactive mode + tests#1704

Closed
Copilot wants to merge 3 commits intodevelopfrom
copilot/add-command-line-parameters-non-interactive
Closed

bench new-app: add CLI options for non-interactive mode + tests#1704
Copilot wants to merge 3 commits intodevelopfrom
copilot/add-command-line-parameters-non-interactive

Conversation

Copy link

Copilot AI commented Mar 14, 2026

  • Understand the issue: bench new-app blindly forwards --app-title etc. to frappe's make-app without checking if frappe version supports them (same problem as --no-git before v14 guard was added)
  • Add version guard in bench/app.py::new_app(): if any non-interactive params are provided and frappe_version < 15, show a clear error and return without calling make-app
  • Update tests in bench/tests/test_utils.py to cover:
    • Non-interactive params are rejected with frappe < 15
    • Non-interactive params are forwarded with frappe >= 15 (existing tests already cover this)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: netchampfaris <9355208+netchampfaris@users.noreply.github.com>
Copilot AI changed the title [WIP] Add ability to pass command line parameters for non interactive mode Add non-interactive mode to bench new-app via CLI parameters Mar 14, 2026
Copilot AI requested a review from netchampfaris March 14, 2026 19:21
Co-authored-by: netchampfaris <9355208+netchampfaris@users.noreply.github.com>
Copilot AI changed the title Add non-interactive mode to bench new-app via CLI parameters bench new-app: add CLI options for non-interactive mode + tests Mar 14, 2026
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants