Skip to content

fix(easy-install): support Traefik v3 SITES_RULE and add safe site mismatch handling#1701

Open
Rocket-Quack wants to merge 3 commits intofrappe:developfrom
Rocket-Quack:fix-easy-install-traefik-site-rules
Open

fix(easy-install): support Traefik v3 SITES_RULE and add safe site mismatch handling#1701
Rocket-Quack wants to merge 3 commits intofrappe:developfrom
Rocket-Quack:fix-easy-install-traefik-site-rules

Conversation

@Rocket-Quack
Copy link

#1696
Fixed because frappe-docker now accepts a different format for site_rules due to traefik updates.

Summary

This PR updates easy-install.py for Traefik v3-compatible site routing and adds safer handling when --sitename differs from an existing project .env

Changes

  • switched env write format from legacy SITES to SITES_RULE (Traefik v3 style)
  • added backward-compatible read fallback for legacy SITES
  • added deprecation warning when legacy SITES is detected
  • added --confirm-site-mismatch option for build, deploy, and upgrade
  • when .env sites differ from CLI --sitename:
    • warns and aborts by default
    • proceeds only if --confirm-site-mismatch is provided
  • updated README.md for new flag and migration behavior

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant