chore: use ecdsa certs and secp384r1#1687
Merged
akhilnarang merged 1 commit intofrappe:developfrom Jan 12, 2026
Merged
Conversation
this patch follows the default in let's encrypt and make use of the stronger secp384r1 curve
|
There was a problem hiding this comment.
Pull request overview
This PR changes the Let's Encrypt certificate configuration from RSA 4096-bit keys to ECDSA certificates using the secp384r1 elliptic curve. The change aims to use a stronger cryptographic approach, though the PR description's claim about following Let's Encrypt defaults is inaccurate (Let's Encrypt actually defaults to RSA 2048-bit, not ECDSA).
Changes:
- Replaced RSA key configuration with ECDSA key type and secp384r1 curve in the Let's Encrypt configuration template
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 5.29.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this patch follows the default in let's encrypt and make use of the stronger secp384r1 curve