Fix build script platform behavior#33
Merged
fpagliughi merged 3 commits intofpagliughi:masterfrom Jun 21, 2025
Merged
Conversation
The old method used `cfg` directives based on target architecture. This was not correct, as the build script is always built for the host architecture. Instead, the build script should use the environment variable provided by cargo to detect the architecture for which the associated crate will be built.
Owner
|
Yeah, that's so confusing. It tripped me up on all my projects a while back, and I still haven't gone through to see which ones still aren't fixed yet. Thanks! I'm gonna revert out the version change in the main Cargo.toml. Technically the -sys crate is separate (and published separately), and only that one needs to be updated and published. Though I guess I should make a separate CHANGELOG for the -sys crate. |
fpagliughi
added a commit
that referenced
this pull request
Jun 21, 2025
Contributor
Author
|
Awesome, any idea when you plan to do another release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old method used
cfgdirectives based on target architecture. This was not correct, as the build script is always built for the host architecture. Instead, the build script should use the environment variable provided by cargo to detect the architecture for which the associated crate will be built.