refactor: Newt runtime lifecycle to context-driven worker supervision.#300
Draft
LaurenceJJones wants to merge 2 commits intofosrl:devfrom
Draft
refactor: Newt runtime lifecycle to context-driven worker supervision.#300LaurenceJJones wants to merge 2 commits intofosrl:devfrom
LaurenceJJones wants to merge 2 commits intofosrl:devfrom
Conversation
Replace stop-channel orchestration with scoped context cancellation for tunnel and interval workers, add errgroup-based supervision for long-running services, and simplify shutdown to fail fast so Docker/systemd handles restarts.
LaurenceJJones
commented
Apr 7, 2026
| // startAuthDaemon initializes and starts the auth daemon. | ||
| // It validates requirements (Linux, root, preshared key) and runs the server | ||
| // until the provided context is cancelled. | ||
| func startAuthDaemon(ctx context.Context) error { |
Member
Author
There was a problem hiding this comment.
Will check if code is reused in pangolin cli as this may break as the function doesnt automatically run in a go routine now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
Replace stop-channel orchestration with scoped context cancellation for tunnel and interval workers, add errgroup-based supervision for long-running services, and simplify shutdown to fail fast so Docker/systemd handles restarts.
also will help #24 as we dont return after interval we keep going to max interval ceiling, we should maybe also add flags or env that if we reach max interval to just kill process as we dont know if we need a new state to revive.
How to test?
Pure internal refactor.