Skip to content

FIO-10202: fixed an issue where Edit Grid with calculateOnServer: true field adds empty row on Blank Submission#272

Merged
johnformio merged 1 commit intomasterfrom
FIO-10202-Edit-Grid-with-calculateOnServer
Jun 30, 2025
Merged

FIO-10202: fixed an issue where Edit Grid with calculateOnServer: true field adds empty row on Blank Submission#272
johnformio merged 1 commit intomasterfrom
FIO-10202-Edit-Grid-with-calculateOnServer

Conversation

@KatrinKhilko
Copy link
Copy Markdown
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-10202

Description

After #237 eachComponentData method iterates through all components that caused firing calculation process for component inside editGrid even if submission is blank. Added condition to shouldCalculate method to prevent unnecessary calculations.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

tested manually, added test
all tests pass locally

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio johnformio merged commit dde72ef into master Jun 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants