FIO-10263: rely on instance level evaluation context to provide us with submission variable#264
Merged
lane-formio merged 1 commit intomasterfrom Jun 10, 2025
Merged
FIO-10263: rely on instance level evaluation context to provide us with submission variable#264lane-formio merged 1 commit intomasterfrom
lane-formio merged 1 commit intomasterfrom
Conversation
TanyaGashtold
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-10263
Description
When we validate on the renderer, we don't provide a submission value into the context. This is a problem, because evaluation contexts need the submission variable as part of the stuff we provide the form user. However, when I made updates to the Evaluator, I accidentally added a submission "overwrite" to the evaluation context instead of just relying on what we get from the instance itself. This PR fixes the error.
Breaking Changes / Backwards Compatibility
n/a
Dependencies
n/a
How has this PR been tested?
Tests for this really belong in formio.js - I will add some and link them here.
Checklist: