FIO-10213: DataSource should add fecthed data into context.data to ma…#261
Closed
yauheni-formio wants to merge 1 commit intomasterfrom
Closed
Conversation
…ke custom conditional components work properly
7 tasks
brendanbond
requested changes
Jun 5, 2025
Contributor
brendanbond
left a comment
There was a problem hiding this comment.
This doesn't seem like a good way to determine the model type for Data Source components. Can we discuss your thinking here?
Author
Author
|
One small addition. In server processes we fetch data for dataSource, in evaluate process we process custom logic, which is tied to fetchedData. If we remove fetchedData in filterPostProcess from context.data, then evaluate process cannot work correctly for conditions with custom logic. That's why you need to leave fetched Data as I stated above |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

…ke custom conditional components work properly
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-10213
Description
What changed?
I leave dataSource fetched data in context.data (Previously fetched data does not get into context.data due to filterPostProcess). Components with custom conditional logic tied to dataSource fecthed data can now handle it correctly and set the correct flags in conditionallyHidden. This allows us to fix the behavior when the submission contains hidden fields.
Breaking Changes / Backwards Compatibility
n/a
Dependencies
This PR is added into formio/formio#1998
How has this PR been tested?
Manually. A test added here: formio/formio#1998
Checklist: