FIO-10159: fixed an issue where value of the Custom component is not saved#259
Closed
KatrinKhilko wants to merge 1 commit intomasterfrom
Closed
FIO-10159: fixed an issue where value of the Custom component is not saved#259KatrinKhilko wants to merge 1 commit intomasterfrom
KatrinKhilko wants to merge 1 commit intomasterfrom
Conversation
brendanbond
requested changes
Jun 5, 2025
Contributor
brendanbond
left a comment
There was a problem hiding this comment.
So are we saying that custom components should always have a model type of "none" here? That doesn't seem right, especially considering that a model type of "none" is basically saying "this is a layout component." Is that what we expect with custom components like this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-10159
Description
What changed?
In his case the value sent to the server has only the key
textFieldCustomin submission data object, but previously core expected it to becustomComponent.textFieldCustom, that caused it is missing when core was trying to get the value from data object. Added a condition to make sure that key in data object andpaths.datapathare the same.Breaking Changes / Backwards Compatibility
n/a
Dependencies
n/a
How has this PR been tested?
tested manually, tests added
Checklist: