Skip to content

FIO-10159: fixed an issue where value of the Custom component is not saved#259

Closed
KatrinKhilko wants to merge 1 commit intomasterfrom
FIO-10159-Value-of-the-Custom-component-is-not-saved
Closed

FIO-10159: fixed an issue where value of the Custom component is not saved#259
KatrinKhilko wants to merge 1 commit intomasterfrom
FIO-10159-Value-of-the-Custom-component-is-not-saved

Conversation

@KatrinKhilko
Copy link
Copy Markdown
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-10159

Description

What changed?

In his case the value sent to the server has only the key textFieldCustom in submission data object, but previously core expected it to be customComponent.textFieldCustom, that caused it is missing when core was trying to get the value from data object. Added a condition to make sure that key in data object and paths.datapath are the same.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

tested manually, tests added

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Copy Markdown
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are we saying that custom components should always have a model type of "none" here? That doesn't seem right, especially considering that a model type of "none" is basically saying "this is a layout component." Is that what we expect with custom components like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants