Conversation
Add a new Enterprise Edition connector for Kraken Pro with read-only capabilities (FetchAccounts, FetchBalances, FetchPayments). - HMAC-SHA512 API authentication with configurable endpoint (UAT/prod) - Offset-based pagination with progressive LastSeenTime tracking - All 16 Kraken ledger types mapped to PSPPayment types - Asset normalization: X/Z prefix stripping, suffix handling, XBT→BTC - Credential validation on Install via GetBalance API call - Non-secret account reference derived from SHA256(APIKey) - Thread-safe currency lazy init via sync.Once - OpenAPI spec with V3KrakenproConfig schema - 73 unit tests (Ginkgo/gomock)
- Remove redundant formattedCurrMap (currencies already uppercase) - Remove ledgerPageSize alias, use PAGE_SIZE directly - Merge latestTime tracking into main ledger iteration loop - Replace strings.Split with strings.IndexByte in truncateToPrecision - Fix misplaced doc comments in assets.go
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
==========================================
+ Coverage 63.09% 63.13% +0.04%
==========================================
Files 832 841 +9
Lines 37635 38065 +430
==========================================
+ Hits 23744 24032 +288
- Misses 12316 12436 +120
- Partials 1575 1597 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
krakenprofor Kraken Pro REST APIFiles
ee/plugins/krakenpro/(connector + client + tests)ee/plugins/list.go,enterprise_ce.go, OpenAPI specTest plan
go build -tags ee ./...compilesgo test -tags ee ./ee/plugins/krakenpro/...— 73 tests passjust pc— full pre-commit passes (tidy, generate, lint, openapi, compile)