Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis PR upgrades the development environment to Go 1.26 and refactors the Nix flake to use separate stable/unstable nixpkgs inputs and a direct Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Run go mod tidy with Go 1.26 to resolve dependency versions correctly - Fix genericclient module require path (v3 -> unversioned, matching replace) - Add replace directive for gopkg.in/go-jose/go-jose.v4 (Go 1.26 enforces module path consistency) - Add .golangci.yml for golangci-lint v2 compatibility (suppress ST* style checks and standard error handling exclusions to match v1 behavior) - Apply Go 1.26 vet auto-fixes (redundant method receivers, loop refactoring) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
=======================================
Coverage 63.08% 63.08%
=======================================
Files 832 832
Lines 37635 37633 -2
=======================================
Hits 23742 23742
+ Misses 12317 12316 -1
+ Partials 1576 1575 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fguery
reviewed
Mar 20, 2026
| @@ -1,19 +1,18 @@ | |||
| { | |||
| description = "A Nix-flake-based Go 1.24 development environment"; | |||
| description = "A Nix-flake-based Go 1.26 development environment"; | |||
Contributor
There was a problem hiding this comment.
We'd also need to change the various docker files
Contributor
There was a problem hiding this comment.
before I forget -- I'm OK with the rest of the PR, but we should also change the dockerfiles :)
The original form !(a && b && c) is clearer than !a || !b || !c. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
flake.nix (1)
26-35: Centralize the nixpkgs import setup.Lines 26-35 now define two inline import shapes. That is fine today, but future overlay or
configchanges are easy to apply to one set and miss on the other. A small helper would keep the shared contract in one place.♻️ Example refactor
- pkgs = import nixpkgs { - inherit system; - overlays = [ nur.overlays.default ]; - config.allowUnfreePredicate = pkg: builtins.elem (nixpkgs.lib.getName pkg) [ - "goreleaser-pro" - ]; - }; - pkgs-unstable = import nixpkgs-unstable { - inherit system; - }; + mkPkgs = source: extra: import source ({ + inherit system; + } // extra); + + pkgs = mkPkgs nixpkgs { + overlays = [ nur.overlays.default ]; + config.allowUnfreePredicate = pkg: builtins.elem (nixpkgs.lib.getName pkg) [ + "goreleaser-pro" + ]; + }; + pkgs-unstable = mkPkgs nixpkgs-unstable {};🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@flake.nix` around lines 26 - 35, Create a single helper that builds the nixpkgs import configuration and use it for both imports instead of duplicating inline calls: extract the shared arguments (system, overlays = [ nur.overlays.default ], and config.allowUnfreePredicate with the goreleaser-pro check) into a function or attribute (e.g., mkNixpkgs or nixpkgsArgs) and then replace the two occurrences of "import nixpkgs { inherit system; overlays = [ nur.overlays.default ]; config.allowUnfreePredicate = pkg: builtins.elem (nixpkgs.lib.getName pkg) [ \"goreleaser-pro\" ]; }" and "import nixpkgs-unstable { inherit system; }" to call that helper (pass a variant flag or override for unstable) so both pkgs and pkgs-unstable are created from the same shared configuration (referencing pkgs, pkgs-unstable, import nixpkgs, import nixpkgs-unstable, overlays, config.allowUnfreePredicate, system).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@flake.nix`:
- Around line 26-35: Create a single helper that builds the nixpkgs import
configuration and use it for both imports instead of duplicating inline calls:
extract the shared arguments (system, overlays = [ nur.overlays.default ], and
config.allowUnfreePredicate with the goreleaser-pro check) into a function or
attribute (e.g., mkNixpkgs or nixpkgsArgs) and then replace the two occurrences
of "import nixpkgs { inherit system; overlays = [ nur.overlays.default ];
config.allowUnfreePredicate = pkg: builtins.elem (nixpkgs.lib.getName pkg) [
\"goreleaser-pro\" ]; }" and "import nixpkgs-unstable { inherit system; }" to
call that helper (pass a variant flag or override for unstable) so both pkgs and
pkgs-unstable are created from the same shared configuration (referencing pkgs,
pkgs-unstable, import nixpkgs, import nixpkgs-unstable, overlays,
config.allowUnfreePredicate, system).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2bb4b32c-942b-450c-9ac7-7ec9d159a669
⛔ Files ignored due to path filters (4)
.golangci.ymlis excluded by!**/*.ymlflake.lockis excluded by!**/*.lock,!**/*.lockgo.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum,!**/*.sum
📒 Files selected for processing (11)
flake.nixinternal/connectors/plugins/public/currencycloud/balances.gointernal/connectors/plugins/public/stripe/client/accounts.gointernal/connectors/plugins/public/stripe/client/external_accounts.gointernal/connectors/plugins/public/stripe/client/payments.gointernal/models/payment_adjustment_id_test.gointernal/models/payment_id_test.gointernal/storage/connectors.gointernal/storage/migrations/1-connector-configs.gointernal/storage/migrations/utils.gointernal/storage/outbox_test.go
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
flemzord
approved these changes
Mar 25, 2026
laouji
requested changes
Mar 25, 2026
Contributor
laouji
left a comment
laouji
left a comment
There was a problem hiding this comment.
dirty check is failing. let's not merge because there is a diff in unexpected places
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowUnfreePredicateinstead ofallowUnfree = true🤖 Generated with Claude Code