fix: allow refresh-token auth without userName#157
Merged
KaviarasuSakthivadivel merged 1 commit intomainfrom Mar 5, 2026
Merged
fix: allow refresh-token auth without userName#157KaviarasuSakthivadivel merged 1 commit intomainfrom
KaviarasuSakthivadivel merged 1 commit intomainfrom
Conversation
- DataCloudConnection.of() accepts null userName (optional for refresh-token auth) - DataCloudDatabaseMetadata.getUserName() throws SQLException with state 28000 when userName is null - DataCloudDatasource normalizes null userName to empty string for connect path Fixes regression where driver required userName for refresh-token auth (e.g. 'userName is marked non-null but is null').
f66bf77 to
37683f1
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
============================================
+ Coverage 82.70% 82.73% +0.03%
- Complexity 1345 1347 +2
============================================
Files 111 111
Lines 4053 4055 +2
Branches 413 413
============================================
+ Hits 3352 3355 +3
Misses 510 510
+ Partials 191 190 -1
🚀 New features to boost your workflow:
|
mkaufmann
approved these changes
Mar 5, 2026
carsheng
approved these changes
Mar 5, 2026
KaviarasuSakthivadivel
pushed a commit
that referenced
this pull request
Mar 6, 2026
🤖 I have created a release *beep* *boop* --- ## [0.42.2](v0.42.1...v0.42.2) (2026-03-05) ### Bug Fixes * allow refresh-token auth without userName ([#157](#157)) ([97bc515](97bc515)) * properly handle thread interrupts during gRPC channel shutdown ([#159](#159)) ([b0a96d1](b0a96d1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression where driver required userName for refresh-token auth (e.g. 'userName is marked non-null but is null').