fix(build): resolve Windows DLL loading and GLIBC compatibility issues#39
Merged
fix(build): resolve Windows DLL loading and GLIBC compatibility issues#39
Conversation
- Add libiconv as static library dependency to fix Windows Error 126 (missing libiconv-2.dll dependency) - Update Linux glibc builds to use ubuntu-22.04 for GLIBC 2.35 compatibility - Fix CMake flag typos (:: to :) for ENABLE_ZLIB, ENABLE_EXPAT, ENABLE_LZO, ENABLE_CPIO - Update inspection steps to fail if no compiled libraries found - Fix workflow library detection to handle multiple file types correctly closes #35, closes #38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two critical issues with the native gem builds:
Windows DLL Loading (Issue Compiled library failed to load on Windows 2025 Docker container #35): The Windows gem was failing with Error 126 because libarchive.dll depends on libiconv-2.dll which was not bundled. Fixed by building libiconv as a static library and linking it into libarchive.
GLIBC Compatibility (Issue Runtime failure due to cannot find compiled library on Debian/Ubuntu/Windows #38): Linux glibc binaries built on Ubuntu 24.04 (GLIBC 2.39) were incompatible with older systems. Fixed by building on Ubuntu 22.04 (GLIBC 2.35) for broader compatibility.
Changes
Windows DLL Loading Fix
GLIBC Compatibility Fix
Additional Fixes
Test Plan
Fixes #35
Fixes #38