This repository was archived by the owner on Feb 10, 2019. It is now read-only.
Fix Lumen 5.5 compability#401
Open
treschelet wants to merge 2 commits into
Open
Conversation
|
Why is the PR titled "Laravel 5.5" but touches the LumenServiceProvider, can you clarify? |
Author
|
I'm sorry this changes were made for lumen |
mfn
reviewed
Nov 6, 2018
| public function connectionFieldFromEdgeType($edgeType, $config = []) | ||
| { | ||
| $typeName = array_get($edgeType->config, 'name'); | ||
| $typeName = $edgeType->name ? $edgeType->name : get_class($edgeType); |
There was a problem hiding this comment.
Is this related to Lumen compatibility or a separate fix?
Author
There was a problem hiding this comment.
Probably it's а separate fix, I include it to this pull request because test in CI for php 7.1 are failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.