This repository was archived by the owner on Feb 10, 2019. It is now read-only.
Verify that a type name is specified before overriding class's type name#366
Open
sburba wants to merge 1 commit into
Open
Verify that a type name is specified before overriding class's type name#366sburba wants to merge 1 commit into
sburba wants to merge 1 commit into
Conversation
Author
|
Looks like that build failure is 5.6 failing for an unrelated reason. It just timed out before doing anything as far as I can tell. I'm not sure how to kick it off again if that's what needs to be done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #365
The schema actually gets the correct types, it's just the GraphQL facade that doesn't load them correctly. Which means GraphQL::type() doesn't work for types specified in the types array of a schema.
Although really only the second and later types fail because 0 coerces to false and is therefore ignored