Skip to content
This repository was archived by the owner on Feb 10, 2019. It is now read-only.

Fix typo in advanced document#363

Open
acro5piano wants to merge 2 commits into
folkloreinc:developfrom
acro5piano:develop
Open

Fix typo in advanced document#363
acro5piano wants to merge 2 commits into
folkloreinc:developfrom
acro5piano:develop

Conversation

@acro5piano

@acro5piano acro5piano commented Jul 26, 2018

Copy link
Copy Markdown

Thanks for the great library.

I found a typo in advances docs so would like to fix it.
My editor also removed trailing spaces...

@acro5piano acro5piano changed the title Fix advanced document typo Fix typo in advanced document Jul 26, 2018
@coveralls

coveralls commented Jul 26, 2018

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 70.537% when pulling 24d693d on acro5piano:develop into 171631a on Folkloreatelier:develop.

Comment thread docs/advanced.md Outdated
```php
// config/graphql.php
'types' => [TestEnum' => TestEnumType::class ];
'types' => ['TestEnum' => TestEnumType::class ];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace after class can also be removed. Feels unbalanced currently 🤷‍♀️

Comment thread docs/advanced.md
```php
// config/graphql.php
'types' => [TestEnum' => TestEnumType::class ];
'types' => ['TestEnum' => TestEnumType::class];

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following @mfn removed whitespace too

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants