fix(snacks): forward cwd to snacks picker items#648
Open
barspielberg wants to merge 6 commits intofolke:mainfrom
Open
fix(snacks): forward cwd to snacks picker items#648barspielberg wants to merge 6 commits intofolke:mainfrom
barspielberg wants to merge 6 commits intofolke:mainfrom
Conversation
Contributor
|
This PR is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
stale
folke
requested changes
Sep 15, 2025
lua/trouble/sources/snacks.lua
Outdated
| source = "snacks", | ||
| buf = item.buf, | ||
| filename = item.file, | ||
| filename = item.cwd and vim.fs.joinpath(item.cwd, item.file) or item.file, |
Owner
There was a problem hiding this comment.
instead of the join here, it should be enough to also assign cwd = item.cwd.
folke
changed the title
folke
reviewed
Sep 15, 2025
lua/trouble/item.lua
Outdated
Comment on lines
40
to
41
| local path = self.cwd and vim.fs.joinpath(self.cwd, self.filename) or self.filename | ||
| self.filename = vim.fs.normalize(path) |
Author
There was a problem hiding this comment.
You are right, I handled the normalization wrong 🤦
I'll normalize the filename first, and also the cwd
Author
There was a problem hiding this comment.
@folke let me know if there is anything else you think I need to fix here
github-actions
bot
removed
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where
trouble_opendidn’t respect thecwdin the Snacks Picker integration.Right now, if you use something like:
You’ll see the right results, but navigation breaks unless you're in the same root directory. This is especially annoying when working in a monorepo and searching inside a specific package.
Related Issue(s)