Float window size as negative value, float window sizes and positions as either numver or function#505
Open
Rumi152 wants to merge 2 commits intofolke:mainfrom
Open
Float window size as negative value, float window sizes and positions as either numver or function#505Rumi152 wants to merge 2 commits intofolke:mainfrom
Rumi152 wants to merge 2 commits intofolke:mainfrom
Conversation
Float window size can be specified in negatives to set size n smaller than parent. Float window position and size can be either number or function that gets parent size as parameter and returns a number
Contributor
|
This PR is stale because it has been open 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Floating window opts can have position at negative values to be relative to right side of window, I have added so they can have negative size as being n smaller than parent.
Second change is I have added possibility for size and position of floating windows to be fun(parent_size: {width: number, height: number}):number. It allows for more customization with runtime calculations