MODLOGSAML-199: Remove legacy token support

[steveellis]

https://folio-org.atlassian.net/browse/MODLOGSAML-199

• Add @Deprecated to SamlConfiguration.useSecureTokens.
• Remove all calls to legacy /token endpoint.
• Let /callback and /callback-with-expiry when called return expiring token cookies (they should already).
• Remove dependence on useSecureTokens because we no longer need a boolean flag to determine if legacy tokens should be used on the /callback endpoint (see MODLOGSAML-192 for background).
• Remove IdpLegacyTest because it works only with the old tokens.
• Rename mock_..._legacy.json in mock files to _callback etc since /callback isn't "legacy" or deprecated anymore.
• Keep useSecureTokens in mocks since it is likely to be present for the time being in configuration.
• Fix DAO tests since they grab config directly out JSON response. Use @JsonIgnore to keep from being written.
• Keep calls to old /token endpoint in mocks but change response to 404.

[barbaraloehle]

After using an new mock configuration,
here mock.setMockContent("mock_content_callback.json"); ,
it is necessary to use
dataMigrationHelper.dataMigrationCompleted(vertx, context, false);
to overwrite the data in the database.
Otherwise the data of
public void setUp(TestContext context)
are used.

[barbaraloehle]

After using an new mock configuration,
here mock.setMockContent("mock_content_callback.json"); ,
it is necessary to use
dataMigrationHelper.dataMigrationCompleted(vertx, context, false);
to overwrite the data in the database.
Otherwise the data of
public void setUp(TestContext context)
are used.

[barbaraloehle]

After using an new mock configuration in the class SamlAPITest
the method
dataMigrationHelper.dataMigrationCompleted(vertx, context, false);
has to be added to overwrite the data in the database.

This has further to be applied to the methods:
public void putConfiguration()
--> public void putConfiguration(context)
and
private void testCallbackErrorCases(String callbackUrl, String relayState, ???
String cookie) -->
private void testCallbackErrorCases(String callbackUrl, String relayState, ???
String cookie, TestContext context)

[barbaraloehle]

In the description of MODLOGSAML-199 the following is mentioned :
"Use /saml/callback by default when enabling mod-login-saml for a tenant the first time."
How can this be garanteed?
Eeventually this could be garanteed by generating a configuration with "saml.callback": "callback" in the class TenantRefAPI using the method

  Future<Integer> loadData(TenantAttributes attributes, String tenantId,
      Map<String, String> headers, Context vertxContext) {
    log.info("TenantRefAPI::loadData");
    return super.loadData(attributes, tenantId, headers, vertxContext)
        .compose(result -> {
          **if (attributes.getModuleFrom() == null) {               
            return Future.succeededFuture(0);
          }**
          return configurationsMigration(headers, vertxContext);
        });
  }

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE