Merged
Conversation
* Implemented a possibility to save and load team matches via json files and added autosaving in case of crashes * fixed team scores not updating when loading * main timer will now stop after second waza-ari (by fixing sm order) fixes #88 * added saving of text and bg colors for an encounter * addressed some issues of the pr - removed catch all from autosaving - fixed file open mode - fixed nullptr referencing - fixed wrong error handling - added input validation - added consts for default save file name and version - added reset confirmation when clicking new - added possibility to load file even with mismatched version number * Refactor team save/load helpers - separated UI from tournament data serialization logic - created TournamentSerialization class to handle saving/loading tournament data to/from JSON - added tests for tournament serialization - renamed "File" menu to "Tournament" and "Open File" to "Load" for better clarity - updated UI strings to reflect tournament context - removed action "Save File" in favor of "Save As" to emphasize saving tournament data * Simplified autosave logic - always saving and loading from default autosave file - added test for auto loading - using default directory (currently application dir) instad of home (still todo: use appdata) * Storing autosave into recommended app data/app config location * Bumped up version number * Fixing warning due to overlapping data member * Updating translations Co-authored-by: mahrtwig <leseratte-MaHa@web.de>
- missing function declaration SetFight - using ensure_qt_app to only create one app instance within the tests - catch2 adaptions - re-formated with clang
- fixes #83 - proper resolution of the testsData path in the tests so the test executable can be started from any directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.