Add send_keepalive_packet option to out_forward plugin#5262
Open
2ZZ wants to merge 1 commit intofluent:masterfrom
Open
Add send_keepalive_packet option to out_forward plugin#52622ZZ wants to merge 1 commit intofluent:masterfrom
2ZZ wants to merge 1 commit intofluent:masterfrom
Conversation
This adds the send_keepalive_packet configuration parameter to enable TCP keepalive (SO_KEEPALIVE) on forward output connections, similar to the implementation in in_forward (PR fluent#2352). The existing 'keepalive' parameter only enables connection pooling, not TCP-level keepalive probes.
Contributor
|
@2ZZ Can you add DCO sign in your commit and fix tests ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
send_keepalive_packetconfiguration parameter to theout_forwardplugin to enable TCP keepalive (SO_KEEPALIVE) on forward output connections.Background
The existing
keepaliveparameter only enables connection pooling/reuse, not TCP-level keepalive probes. This can lead to accumulation of dead connections in CLOSE-WAIT state.Changes
send_keepalive_packetconfig parameter (default: false)socket_create_tcpandsocket_create_tlscallsRelated
This follows the same pattern as #2352 which added the same feature to
in_forward.