Skip to content

Comments

rake: check GEM_HOST_API_KEY in advance#5258

Merged
kenhys merged 1 commit intofluent:masterfrom
kenhys:ensure-api-key
Feb 13, 2026
Merged

rake: check GEM_HOST_API_KEY in advance#5258
kenhys merged 1 commit intofluent:masterfrom
kenhys:ensure-api-key

Conversation

@kenhys
Copy link
Contributor

@kenhys kenhys commented Feb 13, 2026

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:

Without it, if you terminate process, you must
manually gem push variant gems such as
-x64-mingw-ucrt.gem, -x64-mingw32.gem and -x86-mingw32.gem.

e.g.

rake release
fluentd 1.19.0 built to pkg/fluentd-1.19.0.gem.
Tag v1.19.0 has already been created.
Missing required environment variable: GEM_HOST_API_KEY
See https://guides.rubygems.org/api-key-scopes/

Docs Changes:

N/A

Release Note:

N/A

Without it, if you terminate process, you must
manually gem push variant gems such as
-x64-mingw-ucrt.gem, -x64-mingw32.gem and -x86-mingw32.gem.

e.g.

  > rake release
  fluentd 1.19.0 built to pkg/fluentd-1.19.0.gem.
  Tag v1.19.0 has already been created.
  Missing required environment variable: GEM_HOST_API_KEY
  See https://guides.rubygems.org/api-key-scopes/

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys kenhys requested a review from Watson1978 February 13, 2026 01:52
@kenhys kenhys added the backport to v1.19 We will backport this fix to the LTS branch label Feb 13, 2026
@Watson1978 Watson1978 added this to the v1.20.0 milestone Feb 13, 2026
Copy link
Contributor

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@kenhys kenhys merged commit 35152fd into fluent:master Feb 13, 2026
35 of 37 checks passed
@kenhys kenhys deleted the ensure-api-key branch February 13, 2026 03:17
github-actions bot pushed a commit that referenced this pull request Feb 15, 2026
**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:

Without it, if you terminate process, you must
manually gem push variant gems such as
-x64-mingw-ucrt.gem, -x64-mingw32.gem and -x86-mingw32.gem.

e.g.

  > rake release
  fluentd 1.19.0 built to pkg/fluentd-1.19.0.gem.
  Tag v1.19.0 has already been created.
  Missing required environment variable: GEM_HOST_API_KEY
  See https://guides.rubygems.org/api-key-scopes/

**Docs Changes**:

N/A

**Release Note**:

N/A

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Watson1978 Watson1978 added the backported "backport to LTS" is done label Feb 16, 2026
Watson1978 pushed a commit that referenced this pull request Feb 16, 2026
**Which issue(s) this PR fixes**: 
Backport #5258
Fixes #

**What this PR does / why we need it**: 

Without it, if you terminate process, you must
manually gem push variant gems such as
-x64-mingw-ucrt.gem, -x64-mingw32.gem and -x86-mingw32.gem.

e.g.

  > rake release
  fluentd 1.19.0 built to pkg/fluentd-1.19.0.gem.
  Tag v1.19.0 has already been created.
  Missing required environment variable: GEM_HOST_API_KEY
  See https://guides.rubygems.org/api-key-scopes/

**Docs Changes**:

N/A

**Release Note**: 

N/A

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kentaro Hayashi <hayashi@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport to v1.19 We will backport this fix to the LTS branch backported "backport to LTS" is done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants