out_azure_kusto: Azure Kusto Cloud Environment Support#2384
out_azure_kusto: Azure Kusto Cloud Environment Support#2384tanmaya-panda1 wants to merge 6 commits intofluent:masterfrom
Conversation
…urce properties to Azure Kusto docs Co-authored-by: tanmaya-panda1 <108695755+tanmaya-panda1@users.noreply.github.com>
…ronym in azure_kusto.md Co-authored-by: tanmaya-panda1 <108695755+tanmaya-panda1@users.noreply.github.com>
Co-authored-by: tanmaya-panda1 <108695755+tanmaya-panda1@users.noreply.github.com>
Co-authored-by: tanmaya-panda1 <108695755+tanmaya-panda1@users.noreply.github.com>
…perties Add Azure Kusto sovereign/private cloud configuration properties
📝 WalkthroughWalkthroughDocumentation for Azure Kusto connector expanded with four new configuration keys supporting private and sovereign cloud deployments: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pipeline/outputs/azure_kusto.md (1)
63-66: Clarify whencloud_namevs custom endpoints apply.Current wording could be read as requiring custom endpoints for all sovereign clouds. Consider clarifying that
cloud_namecovers public sovereign clouds (e.g., AzureUSGovernmentCloud), while custom endpoints are for private clouds or non-standard sovereign endpoints, and that custom endpoints override/replacecloud_namewhen set.💡 Suggested wording tweak
-| `cloud_name` | Set the Azure cloud environment. Supported values: `AzureCloud` (default), `AzureChinaCloud`, `AzureUSGovernmentCloud`. For private clouds, set `cloud_login_host`, `cloud_kusto_scope`, and `cloud_kusto_resource` instead. | `AzureCloud` | -| `cloud_login_host` | Custom OAuth login host for private/sovereign clouds (for example, `login.microsoftonline.eaglex.ic.gov`). When set, `cloud_kusto_scope` and `cloud_kusto_resource` must also be provided. | _none_ | -| `cloud_kusto_scope` | Custom Kusto OAuth scope for private/sovereign clouds (for example, `https://help.kusto.core.eaglex.ic.gov/.default`). When set, `cloud_login_host` and `cloud_kusto_resource` must also be provided. | _none_ | -| `cloud_kusto_resource` | Custom Kusto IMDS resource URL for private/sovereign clouds (for example, `https://api.kusto.core.eaglex.ic.gov/`). When set, `cloud_login_host` and `cloud_kusto_scope` must also be provided. | _none_ | +| `cloud_name` | Set the Azure cloud environment. Supported values: `AzureCloud` (default), `AzureChinaCloud`, `AzureUSGovernmentCloud`. Use custom endpoints only for private clouds or non-standard sovereign endpoints. | `AzureCloud` | +| `cloud_login_host` | Custom OAuth login host for private clouds or non-standard sovereign endpoints (for example, `login.microsoftonline.eaglex.ic.gov`). When set, `cloud_kusto_scope` and `cloud_kusto_resource` must also be provided and take precedence over `cloud_name`. | _none_ | +| `cloud_kusto_scope` | Custom Kusto OAuth scope for private clouds or non-standard sovereign endpoints (for example, `https://help.kusto.core.eaglex.ic.gov/.default`). When set, `cloud_login_host` and `cloud_kusto_resource` must also be provided. | _none_ | +| `cloud_kusto_resource` | Custom Kusto IMDS resource URL for private clouds or non-standard sovereign endpoints (for example, `https://api.kusto.core.eaglex.ic.gov/`). When set, `cloud_login_host` and `cloud_kusto_scope` must also be provided. | _none_ |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pipeline/outputs/azure_kusto.md` around lines 63 - 66, The docs are ambiguous about when to use cloud_name vs custom endpoints; update the description for cloud_name and the three custom fields (cloud_login_host, cloud_kusto_scope, cloud_kusto_resource) to state that cloud_name covers built-in public/sovereign Azure clouds (e.g., AzureCloud, AzureChinaCloud, AzureUSGovernmentCloud) and that custom endpoints are only required for private or non-standard sovereign environments, and that providing any of cloud_login_host/cloud_kusto_scope/cloud_kusto_resource overrides/replaces cloud_name for authentication and Kusto calls; ensure the text explicitly notes the required co-dependency between cloud_login_host, cloud_kusto_scope, and cloud_kusto_resource.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pipeline/outputs/azure_kusto.md`:
- Around line 63-66: The docs are ambiguous about when to use cloud_name vs
custom endpoints; update the description for cloud_name and the three custom
fields (cloud_login_host, cloud_kusto_scope, cloud_kusto_resource) to state that
cloud_name covers built-in public/sovereign Azure clouds (e.g., AzureCloud,
AzureChinaCloud, AzureUSGovernmentCloud) and that custom endpoints are only
required for private or non-standard sovereign environments, and that providing
any of cloud_login_host/cloud_kusto_scope/cloud_kusto_resource
overrides/replaces cloud_name for authentication and Kusto calls; ensure the
text explicitly notes the required co-dependency between cloud_login_host,
cloud_kusto_scope, and cloud_kusto_resource.
eschabell
left a comment
There was a problem hiding this comment.
Once the code PR merges, this is good to go.
This pull request updates the Azure Kusto output documentation to add support for configuring private and sovereign cloud environments. The main changes are new configuration options that allow users to specify custom endpoints and resource URLs for these environments.
Azure Kusto Cloud Environment Support:
cloud_nameoption to specify the Azure cloud environment (default:AzureCloud). For private clouds, users should set custom endpoints instead.cloud_login_host,cloud_kusto_scope, andcloud_kusto_resourceoptions for specifying custom OAuth endpoints and resource URLs required for private or sovereign Azure clouds. These must be provided together when targeting such environments.Summary by CodeRabbit