2319 interval pentagon ai interval expression semantics by schuler-henry · Pull Request #2321 · flowr-analysis/flowr

schuler-henry · 2026-02-09T22:32:27Z

NumericInferenceVisitor

Constant number resolution for integers and double.
Expression semantics for +, -, *, length

(note: pr includes one flowr release patch (2.9.9))

Added rudimentary support for inferring scalar numeric values using the NumericInferenceVisitor. First support for: +, -, *, length.

Tests for: +, -, *, length.

…n-semantics

- Removed interprocedural and loop test, as we do not support it yet - Updated threshold when comparing floating point numbers to be relative to the number (as larger numbers produce larger errors)

OliverGerstl

Looks generally good :D
Most of the comments are general hints/ideas and minor issues.
We can talk about this later.

src/abstract-interpretation/domains/interval-domain.ts

src/abstract-interpretation/interval/numeric-inference.ts

src/abstract-interpretation/interval/semantics.ts

test/functionality/abstract-interpretation/interval/interval.ts

test/functionality/abstract-interpretation/interval/inference.test.ts

- Updated domain functions equals and leq to return ternary values in order to represent results based on significant figures precision comparison. - Refactored code with review from PR

- Argument value resolution is delayed until the arguments are needed to increase performance and allow evaluating potential non-numeric arguments via constant propagation. - Updated test cases to include tests for missing/to many function arguments.

schuler-henry · 2026-02-11T15:14:10Z

@OliverGerstl I have applied your feedback.
@EagleoutIce, it would be great if you could take a look at the changes, especially whether my implementation of the Ternary return value for equal and leq in the domains was what you had in mind.
Feel free to suggest other solutions.

src/abstract-interpretation/domains/interval-domain.ts

src/abstract-interpretation/interval/semantics.ts

src/abstract-interpretation/domains/abstract-domain.ts

src/abstract-interpretation/domains/bounded-set-domain.ts

src/abstract-interpretation/domains/interval-domain.ts

test/functionality/abstract-interpretation/interval/inference.test.ts

test/functionality/abstract-interpretation/interval/interval.ts

…expression-semantics # Conflicts: # src/abstract-interpretation/absint-visitor.ts # src/documentation/wiki-absint.ts

src/abstract-interpretation/interval/expression-semantics.ts

src/abstract-interpretation/domains/abstract-domain.ts

src/abstract-interpretation/domains/interval-domain.ts

src/abstract-interpretation/interval/expression-semantics.ts

src/abstract-interpretation/domains/interval-domain.ts

src/abstract-interpretation/interval/expression-semantics.ts

src/util/logic.ts

src/abstract-interpretation/domains/interval-domain.ts

schuler-henry added 6 commits February 4, 2026 16:33

feat: updated interval domain to allow +Inf and -Inf

a37ba51

feat: initial NumericInferenceVisitor and first semantics

2b334dc

Added rudimentary support for inferring scalar numeric values using the NumericInferenceVisitor. First support for: +, -, *, length.

Merge branch 'main' into staging/henry

3a3da5d

feat: tests for interval expression semantics

f2522bb

Tests for: +, -, *, length.

Merge branch 'main' into 2319-interval-pentagon-ai-interval-expressio…

ed91a53

…n-semantics

tests-fix: relative threshold for number comparison

2fe5aad

- Removed interprocedural and loop test, as we do not support it yet - Updated threshold when comparing floating point numbers to be relative to the number (as larger numbers produce larger errors)

schuler-henry requested a review from OliverGerstl February 9, 2026 22:32

schuler-henry self-assigned this Feb 9, 2026

OliverGerstl reviewed Feb 10, 2026

View reviewed changes

schuler-henry added 2 commits February 11, 2026 11:16

feat: introduce significant figures precision to interval domain

6a48576

- Updated domain functions equals and leq to return ternary values in order to represent results based on significant figures precision comparison. - Refactored code with review from PR

schuler-henry requested review from EagleoutIce and OliverGerstl February 11, 2026 15:10

OliverGerstl reviewed Feb 11, 2026

View reviewed changes

refactor: interval semantics

0f33bca

EagleoutIce reviewed Feb 13, 2026

View reviewed changes

schuler-henry added 8 commits February 13, 2026 20:48

feat-fix: applied pr feedback

f3b9aa5

refactor: disable significant figures via undefined

30ba704

refactor: extracted significance prevision comparison logic

e02ac27

refactor: pr feedback

8c58cc8

refactor: revert formatting

d4226b4

refactor: dedicated num-inf sub-logger

432c28d

Merge branch 'main' into staging/henry

4791df2

Merge branch 'staging/henry' into 2319-interval-pentagon-ai-interval-…

9b1aef1

…expression-semantics # Conflicts: # src/abstract-interpretation/absint-visitor.ts # src/documentation/wiki-absint.ts

EagleoutIce reviewed Feb 16, 2026

View reviewed changes

src/abstract-interpretation/interval/expression-semantics.ts Outdated Show resolved Hide resolved

schuler-henry added 2 commits February 16, 2026 19:39

refactor: switch back to boolean for equals and leq

5d2c188

refactor: replaced expected values with calculation

a4414b6

OliverGerstl reviewed Feb 19, 2026

View reviewed changes

schuler-henry mentioned this pull request Feb 19, 2026

Subtype Ternary enum #2351

Open

schuler-henry added 11 commits February 19, 2026 16:30

refactor: removed DEFAULT_SIGNIFICANT_FIGURES

fc42b48

refactor: added non-static scalar version for interval domain

17c9739

refactor: renamed interval semantics to expression-semantics

f6a48b9

refactor: renamed interval expression semantics methods

727d07a

refactor: renamed and restructured SignificancePrecisionComparison

2b19aad

refactor: removed private docstring for floating-point methods

30952a2

feat: minmax number calculation function

967d145

feat: intervalLength semantics now assure 0 inf bounds

159eced

feat: significant figures numeric inference config value

96b1e74

feat: use coarser sig-fig for new interval out of two existing

1dbde74

refactor: replace math pow

dc5ac4b

schuler-henry mentioned this pull request Feb 24, 2026

[interval-pentagon-ai] Generalize expression semantics #2360

Open

schuler-henry requested a review from EagleoutIce February 24, 2026 13:02

EagleoutIce approved these changes Feb 24, 2026

View reviewed changes

src/abstract-interpretation/domains/interval-domain.ts Outdated Show resolved Hide resolved

src/abstract-interpretation/domains/interval-domain.ts Outdated Show resolved Hide resolved

src/abstract-interpretation/domains/interval-domain.ts Outdated Show resolved Hide resolved

refactor: replace isNaN and +-Infinity

0d30f61

schuler-henry merged commit 92d2802 into staging/pentagon-ai Feb 24, 2026
8 checks passed

schuler-henry deleted the 2319-interval-pentagon-ai-interval-expression-semantics branch February 24, 2026 17:38

Conversation

schuler-henry commented Feb 9, 2026

Uh oh!

OliverGerstl left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

schuler-henry commented Feb 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

OliverGerstl left a comment •

edited

Loading