fix: topologically sort CloudFormation resources before provisioning#332
Merged
hectorvent merged 1 commit intofloci-io:mainfrom Apr 11, 2026
Merged
Conversation
b4a73e8 to
c35707b
Compare
c35707b to
67d83de
Compare
Collaborator
|
Thanks @ctnnguyen, I will take a look soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #331
CloudFormationService.executeTemplateprovisioned resources in JSON/YAML field iteration order with no dependency analysis. If a resource referenced another viaRef,Fn::GetAtt, orFn::Sub, and the referenced resource appeared later in the template, the intrinsic function fell back to a literal string (e.g.CredentialsQueue.Arninstead of the actual ARN).Adds a topological sort (Kahn's algorithm) that scans resource
PropertiesforRef,Fn::GetAtt,Fn::Subvariable references (including${Resource}and${Resource.Attr}shorthand), and explicitDependsOndeclarations. Resources with false conditions are excluded from the graph. Cycles fall back to original ordering.Type of change
fix:)feat:)feat!:orfix!:)AWS Compatibility
CloudFormation provisions resources respecting implicit dependencies from
Ref,Fn::GetAtt,Fn::Sub, and explicitDependsOn. Without dependency ordering, templates where a resource appears before its dependency in the file would fail to resolve intrinsic functions correctly.Checklist
./mvnw testpasses locally