Add custom VPP app support #37969
Merged
Add custom VPP app support #37969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next up: wire up environment override on bearer token pull to allow that to work, test end-to-end against Apple API
Next steps: 1. Fix tests 2. Make sure setting apps via GitOps works properly 3. Implement proxy auth management/persistence
Next up: manual testing against fake proxy, automated test updates
…tries Licensing wasn't picking up license keys for dev/expired licenses to pass on to the proxy because licenses weren't passed by ref. Still need to figure out what's wrong with the auth-expired case
…n leaving them after soft-deleting them This has now been end-to-end validated. Just need to write tests now.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #37969 +/- ##
==========================================
+ Coverage 65.82% 65.84% +0.01%
==========================================
Files 2387 2387
Lines 190158 190333 +175
Branches 8428 8428
==========================================
+ Hits 125168 125321 +153
- Misses 53609 53619 +10
- Partials 11381 11393 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Zed + Opus 4.5; prompt: Fix broken fleetctl tests in https://github.com/fleetdm/fleet/actions/runs/20772756036/job/59652047015. This almost certainly involves replacing the fake iTunes server with a fake VPP apps proxy server, setting env vars appropriately to point at that server.
29 tasks
…with hardcoded bearer tokens Also fixes expected retry logic in the apple_apps API test since we're doing that one level up now
Zed + Opus 4.5; prompt: Replace the TODOs in server/mdm/apple/apple_apps/api_test.go with appropriate tests.
…pecific version numbers correctly
Zed + Opus 4.5; prompt: Add a test for 429s/retry-after to TestDoRetries in server/mdm/apple/apple_apps/api_test.go
jahzielv
reviewed
Jan 8, 2026
| Data []Metadata `json:"data"` | ||
| } | ||
|
|
||
| type Authenticator func(forceRenew bool) (string, error) |
Member
There was a problem hiding this comment.
Nit: would be nice to have a comment on this type since it's exported
Member
Author
There was a problem hiding this comment.
Sure. I'll add that if there are any other non-nit changes I need to make to this PR (which there probably are?)
jahzielv
reviewed
Jan 8, 2026
jahzielv
reviewed
Jan 8, 2026
jahzielv
reviewed
Jan 8, 2026
Member
|
overall lgtm other than the couple things pointed out above |
…for the correct number of requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #32481 for Fleet server-side work.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
Changes file added for user-visible changes in
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Input data is properly validated,
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)Testing
Added/updated automated tests
QA'd all new/changed functionality manually