FOGL-10204 : Increased wait time for co-routine by 1 second to finish#1709
Merged
FOGL-10204 : Increased wait time for co-routine by 1 second to finish#1709
Conversation
Signed-off-by: nandan <nandan.ghildiyal@gmail.com>
gnandan
requested review from
MarkRiddoch,
ashish-jabble,
ashwini-k-pandey and
firozalikhan
| await server.Server.scheduler.disable_schedule(sch_id) | ||
| # return control to event loop | ||
| await asyncio.sleep(1) | ||
| await asyncio.sleep(2) |
Member
There was a problem hiding this comment.
How does this gurantee? and why does it works for all other services?
Member
Author
There was a problem hiding this comment.
In case of management service two schedules are created one for Management service and one for FogMan poll Agent. However, for other services only one schedule is there. That's why cleaning up might take some extra time.
praveen-garg
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increased wait time for co-routine so that disable schedule can finish before deleting category