test(firestore): fix broken parent expression test#16018
Merged
andrewheard merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
This test is failing in CI. The pipeline in the test has no input documentats to run against, because the `randomCol` is empty, despite calling `setData` to create a document deeper in the collection. This fixes the test by adding a dummy document to the `randomCol` collection.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
dlarocque
changed the title
parent() expression testparent expression test
Generated by 🚫 Danger |
andrewheard
approved these changes
Apr 1, 2026
Contributor
andrewheard
left a comment
andrewheard
left a comment
There was a problem hiding this comment.
Thank you for resolving this so quickly, @dlarocque!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is failing in CI. The pipeline in the test has no input documentats to run against, because the
randomColis empty, despite callingsetDatato create a document deeper in the collection. This fixes the test by adding a dummy document to therandomColcollection.