Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
This reverts commit 8c5cc9e.
When linting with Xcode 26.4, CI reported:
This commit addresses these warnings along with a detected memory leak.
Summary
Resolves a static analysis failure on tvOS by correcting nullability mismatches and fixing a kernel memory leak in the CPU gauge collection path.
Fixed Warnings
The following static analysis errors were reported during pod lib lint:
* warning: nil returned from a function that is expected to return a non-null value [nullability.NullReturnedFromNonnull]
* error: [tvOS] build_pod: Static Analysis failed.
Changes
* Fixed Memory Leak: Added a missing vm_deallocate call in fprCollectCPUMetric to ensure kernel-allocated thread lists are freed if thread_info fails inside the collection loop.
* Corrected Nullability:
* Marked fprCollectCPUMetric as returning _Nullable to accurately reflect its behavior when system calls (e.g., task_info, task_threads) fail.
* Updated the FPRGaugeManager API (dispatchMetric:) to accept nullable metrics, as it already internally handled nil via type checks.
* Added a safety check in FPRCPUGaugeCollector to prevent passing nil data to its delegate.
* Improved Stability: Ensured that failing to collect CPU metrics no longer triggers static analysis warnings or leaks system resources.
paulb777
left a comment
paulb777
left a comment
There was a problem hiding this comment.
LGTM on acceptable CI and PINNED suggestion merge
andrewheard
left a comment
andrewheard
left a comment
There was a problem hiding this comment.
Note: If CI passes I'd prefer to handle these suggestions separately in #16011 to get them merged.
|
There are still some persistent failures. I'll work on them in smaller PRs that to reduce CI load. |
3 participants
Fast-Follow TODOs
CI & Infrastructure
Authentication
Performance & Quality
#no-changelog