feat(ai): add deprecation notices to Imagen types#15985
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
andrewheard
left a comment
There was a problem hiding this comment.
Please replace imagen with Imagen throughout.
FirebaseAI/Sources/Types/Internal/Imagen/ImagenGenerationRequest.swift
Outdated
Show resolved
Hide resolved
FirebaseAI/Sources/Types/Internal/Imagen/ImagenGenerationRequest.swift
Outdated
Show resolved
Hide resolved
FirebaseAI/Sources/Types/Public/Imagen/ImagenGenerationResponse.swift
Outdated
Show resolved
Hide resolved
|
@daymxn Would you mind merging from |
rachelsaunders
left a comment
There was a problem hiding this comment.
In each of the messages, is it possible to add the link to the migration guide? I just want to make sure folks don't have to go hunting for that info if they see one of these deprecation messages, ya know?
| /// @DeprecationSummary { | ||
| /// All Imagen models are deprecated and will shut down as early as June 2026. | ||
| /// As a replacement, you can [migrate your apps to use Gemini Image models | ||
| /// (the "Nano Banana" models).](https://firebase.google.com/docs/ai-logic/imagen-models-migration) |
There was a problem hiding this comment.
| /// (the "Nano Banana" models).](https://firebase.google.com/docs/ai-logic/imagen-models-migration) | |
| /// (the "Nano Banana" models)](https://firebase.google.com/docs/ai-logic/imagen-models-migration). |
IF you spin up a new PR to address my high-level comment that I just posted, could you pls make this change throughout? It's just a nit, so if you're NOT spinning up a new PR, then don't worry about it at all.
Per b/496563474,
This PR adds deprecation notices to all of the imagen related APIs, to prepare for removal of said APIs in June.
@availablemarkers have been added for each related type, with a descriptive message of what's going on, and how to migrate. Although, since we can't provide links within the annotation message, a matching@DeprecationSummaryhas also been included for each marker.Some minor notes:
@DeprecationSummarymay appear to be odd in a few of the usages. This is due to the way xcode renders the notice. If it's not put after the first summary, then xcode won't render anything else (such as the arguments, or the discussion portion).@availablemarkers still include a message, as this is the message that's actually used in the IDE for warnings. The one in the@DeprecationSummaryis instead used in the generated docs.#ai-logic-imagen-shutdown