Skip to content

chore: remove unused spectesting.yml#15658

Closed
ncooke3 wants to merge 2 commits intomainfrom
nc/remove-spectesting.yml
Closed

chore: remove unused spectesting.yml#15658
ncooke3 wants to merge 2 commits intomainfrom
nc/remove-spectesting.yml

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 2, 2026

Reasons to remove (generated):

  1. Redundancy: The primary goal of spectesting (validating that a Podspec works) is already covered by the standard pod lib lint checks running in other workflows (e.g., common_cocoapods.yml which is called by product-specific workflows like auth.yml, firestore.yml, etc.). pod lib lint is the industry standard for pre-merge validation.
  2. It is Disabled: As you noted, it has been effectively disabled (branches: - none) for over a year, meaning the project has been successfully releasing without it.
  3. Different Purpose: The other two workflows you asked about serve a different purpose:
    • prerelease_cocoapods.yml: Publishes nightly snapshots.
    • release_cocoapods.yml: Stages official releases. * These verify the deployment pipeline, whereas spectesting was a complex local simulation of that pipeline (rewriting podspecs to point to local file paths) which is brittle and largely unnecessary given the other checks.

#no-changelog

   1. Redundancy: The primary goal of spectesting (validating that a Podspec works) is already covered by the standard pod lib lint checks running in other workflows (e.g., common_cocoapods.yml which is called by product-specific workflows like
      auth.yml, firestore.yml, etc.). pod lib lint is the industry standard for pre-merge validation.
   2. It is Disabled: As you noted, it has been effectively disabled (branches: - none) for over a year, meaning the project has been successfully releasing without it.
   3. Different Purpose: The other two workflows you asked about serve a different purpose:
       * prerelease_cocoapods.yml: Publishes nightly snapshots.
       * release_cocoapods.yml: Stages official releases.
       * These verify the deployment pipeline, whereas spectesting was a complex local simulation of that pipeline (rewriting podspecs to point to local file paths) which is brittle and largely unnecessary given the other checks.

#no-changelog
@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@ncooke3 ncooke3 enabled auto-merge (squash) January 2, 2026 18:56
@paulb777
Copy link
Member

paulb777 commented Jan 2, 2026

I'm fine to remove, but disagree with reason number 1. pod lib lint is different from pod spec lint testing. The former tests whatever is in the repo. The latter tests what is explicitly specified in the pod spec. Only doing pod lib lint testing will miss post-release issues.

@ncooke3
Copy link
Member Author

ncooke3 commented Jan 2, 2026

I'm fine to remove, but disagree with reason number 1. pod lib lint is different from pod spec lint testing. The former tests whatever is in the repo. The latter tests what is explicitly specified in the pod spec. Only doing pod lib lint testing will miss post-release issues.

@paulb777 good catch! Will the nightly release and prerelease workflows (pod repo pushes to the testing repos) effectively be the same as pod spec linting?

@paulb777
Copy link
Member

paulb777 commented Jan 2, 2026

Yes, but those only do a subset of the podspecs.

@ncooke3
Copy link
Member Author

ncooke3 commented Jan 2, 2026

Hmm, then I think it may be better to re-enable this workflow.

@ncooke3
Copy link
Member Author

ncooke3 commented Jan 2, 2026

I'll try re-enabling

@ncooke3 ncooke3 closed this Jan 2, 2026
auto-merge was automatically disabled January 2, 2026 19:10

Pull request was closed

@ncooke3 ncooke3 deleted the nc/remove-spectesting.yml branch January 8, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants