Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions firebase-crashlytics-gradle/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
### Unreleased

- [changed] Improved efficiency when extracting breakpad binary files.
- [fixed] Avoid build breaks when handling unsupported native libraries for injectCrashlyticsBuildIds task [#7780]
- [fixed] Fixed an incompatibility between Crashlytics Gradle plugin and Gradle isolated projects when enabling nativeSymbolUploadEnabled. [#8037]

### Crashlytics Gradle plugin version 3.0.7

* [changed] Improved efficiency when extracting breakpad binary files.
* [fixed] Avoid build breaks when handling unsupported native libraries for injectCrashlyticsBuildIds task [#7780]

### Crashlytics Gradle plugin version 3.0.6

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,9 @@ abstract class GenerateSymbolFileTask : DefaultTask() {
symbolGeneratorTypeOverride: Property<String>,
) {
val symbolGeneratorTypeString =
Comment thread
maxsav marked this conversation as resolved.
if (project.hasProperty(SYMBOL_GENERATOR_PROPERTY)) {
project.findProperty(SYMBOL_GENERATOR_PROPERTY) as String
} else if (symbolGeneratorTypeOverride.isPresent) {
symbolGeneratorTypeOverride.get()
} else {
SYMBOL_GENERATOR_BREAKPAD
}
project.providers.gradleProperty(SYMBOL_GENERATOR_PROPERTY)
.orElse(symbolGeneratorTypeOverride)
.getOrElse(SYMBOL_GENERATOR_BREAKPAD)

// This will also validate the symbol generator type string.
symbolGeneratorType.set(SymbolGeneratorType.fromString(symbolGeneratorTypeString))
Expand Down Expand Up @@ -174,8 +170,10 @@ abstract class GenerateSymbolFileTask : DefaultTask() {
project.tasks.register<GenerateSymbolFileTask>(
"generateCrashlyticsSymbolFile${variant.name.capitalized()}"
) {
if (project.hasProperty(BREAKPAD_BINARY_PROPERTY)) {
breakpadBinary.set(File(project.findProperty(BREAKPAD_BINARY_PROPERTY) as String))
val breakpadBinaryGradleProperty =
project.providers.gradleProperty(BREAKPAD_BINARY_PROPERTY)
if (breakpadBinaryGradleProperty.isPresent) {
breakpadBinary.set(File(breakpadBinaryGradleProperty.get()))
} else {
breakpadBinary.set(crashlyticsExtension.breakpadBinary)
}
Expand Down
Loading