Conversation
…lt assertion to reduce false positives in unit tests
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
…lt assertion to reduce false positives in unit tests (#7937)
This PR updates the
ChiSquareTestsignificance result assertions in thefirebase-dataconnectunit tests to be more lax. By changing the rejection threshold from0.0001to0.00001, this change aims to reduce the number of false positives encountered during test execution.The flaky test failure that motivated this PR was https://github.com/firebase/firebase-android-sdk/actions/runs/23309337787/job/67792345315?pr=7936 which had the following counts:
From looking at the chart, the counts definitely have a reasonable standard deviation. Therefore, lowering the rejection threshold makes sense so that a distribution like this in the future does not result in a test failure.
Highlights
ChiSquareTestsignificance assertions to decrease the frequency of false positives in property-based unit tests.Changelog
ChiSquareTest.withDefaults().test()from0.0001to0.00001.