Skip to content

Call back from the firebase transport runtime into the event-emitter …#7928

Open
moltmann wants to merge 1 commit intofirebase:mainfrom
moltmann:main
Open

Call back from the firebase transport runtime into the event-emitter …#7928
moltmann wants to merge 1 commit intofirebase:mainfrom
moltmann:main

Conversation

@moltmann
Copy link

Call back from the firebase transport runtime into the event-emitter if there is an updated pseudonymous ID

This then allows the emitter to store the ID and attach it to future events.

Note: Ideally we would not even attach the ID to the event and rather resolve it directly before the http-call. Not sure why this was not done. But this is not really a big issue as long as the ids are very long living. Then we will we only end up with a small amount of events with stale IDs

I thought about how to best implement the callback.

  • We can unfortunately not just use a regular Consumer class as the callback has to be persistable.
  • Since the firebase transport runtime does not use Hilt's app-wide shared components I don't think we can inject the callback using dagger
  • We could use Android functionality like e.g. a BroadcastReceiver, but this is pretty heavy handed

Internal b/490114654

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@rlazo rlazo requested a review from VinayGuthal March 18, 2026 00:12
VinayGuthal
VinayGuthal previously approved these changes Mar 19, 2026
…if there is an updated pseudonymous ID

This then allows the emitter to store the ID and attach it to future events.

Note: Ideally we would not even attach the ID to the event and rather resolve it directly before the http-call. Not sure why this was not done. But this is not really a big issue as long as the ids are very long living. Then we will we only end up with a small amount of events with stale IDs

I thought about how to best implement the callback.

- We can unfortunately not just use a regular Consumer class as the callback has to be persistable.
- Since the firebase transport runtime does not use Hilt's app-wide shared components I don't think we can inject the callback using dagger
- We could use Android functionality like e.g. a BroadcastReceiver, but this is pretty heavy handed

Internal b/490114654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants