Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions firebase-appdistribution-api/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Unreleased

- [changed] Bumped internal dependencies.

# 16.0.0-beta17

- [changed] Bumped internal dependencies.
Expand Down
2 changes: 2 additions & 0 deletions firebase-appdistribution/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Unreleased

- [changed] Bump internal dependencies.

# 16.0.0-beta17

- [changed] Bumped internal dependencies.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ class FeedbackSender {
static final String CONTENT_TYPE_PNG = "image/png";

private static final String TAG = "FeedbackSender";
private static final String FILE_EXTENSION_JPG = ".jpg";
private static final String FILE_EXTENSION_JPEG = ".jpeg";
private static final String FILE_EXTENSION_PNG = ".png";
private static final String FILE_EXTENSION_JPG = "jpg";
private static final String FILE_EXTENSION_JPEG = "jpeg";
private static final String FILE_EXTENSION_PNG = "png";
private static final String DEFAULT_FILENAME = "screenshot.png";

private final ContentResolver contentResolver;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ public class FeedbackSenderTest {
private static final String TEST_FEEDBACK_TEXT = "Feedback text";
private static final String TEST_FILENAME_PNG = "test.png";
private static final Uri TEST_SCREENSHOT_URI_PNG = uriForFilename(TEST_FILENAME_PNG);
private static final String TEST_FILENAME_JPG = "test.jpg";
private static final Uri TEST_SCREENSHOT_URI_JPG = uriForFilename(TEST_FILENAME_JPG);
private static final String TEST_FILENAME_JPEG = "test.jpeg";
private static final Uri TEST_SCREENSHOT_URI_JPEG = uriForFilename(TEST_FILENAME_JPEG);

@Lightweight private final Executor lightweightExecutor = TestOnlyExecutors.lite();

Expand Down Expand Up @@ -83,28 +87,25 @@ public void sendFeedbackPng() throws Exception {

@Test
public void sendFeedbackJpg() throws Exception {
String jpegFilename = "test.jpg"; // jpg, not jpeg
Uri jpegUri = uriForFilename(jpegFilename);

Task<Void> task =
feedbackSender.sendFeedback(
TEST_RELEASE_NAME, TEST_FEEDBACK_TEXT, jpegUri, FeedbackTrigger.CUSTOM);
TEST_RELEASE_NAME, TEST_FEEDBACK_TEXT, TEST_SCREENSHOT_URI_JPG, FeedbackTrigger.CUSTOM);
TestUtils.awaitTask(task);

verifyTesterApiCalls(jpegUri, jpegFilename, CONTENT_TYPE_JPEG);
verifyTesterApiCalls(TEST_SCREENSHOT_URI_JPG, TEST_FILENAME_JPG, CONTENT_TYPE_JPEG);
}

@Test
public void sendFeedbackJpeg() throws Exception {
String jpegFilename = "test.jpeg"; // jpeg, not jpg
Uri jpegUri = uriForFilename(jpegFilename);

Task<Void> task =
feedbackSender.sendFeedback(
TEST_RELEASE_NAME, TEST_FEEDBACK_TEXT, jpegUri, FeedbackTrigger.CUSTOM);
TEST_RELEASE_NAME,
TEST_FEEDBACK_TEXT,
TEST_SCREENSHOT_URI_JPEG,
FeedbackTrigger.CUSTOM);
TestUtils.awaitTask(task);

verifyTesterApiCalls(jpegUri, jpegFilename, CONTENT_TYPE_JPEG);
verifyTesterApiCalls(TEST_SCREENSHOT_URI_JPEG, TEST_FILENAME_JPEG, CONTENT_TYPE_JPEG);
}

@Test
Expand Down
2 changes: 2 additions & 0 deletions firebase-functions/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Unreleased

- [changed] Bumped internal dependencies.

# 22.1.0

- [changed] Bumped dependency on OkHTTP to version 4.12.0 from version 3.12.13. If your app depends
Expand Down
2 changes: 2 additions & 0 deletions firebase-inappmessaging-display/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Unreleased

- [changed] Bumped internal dependencies.

# 22.0.2

- [changed] Updated `com.github.bumptech.glide:glide` dependency to `5.0.5`. [#7469]
Expand Down
2 changes: 2 additions & 0 deletions firebase-inappmessaging/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Unreleased

- [changed] Bumped internal dependencies.

# 22.0.2

- [changed] Bumped internal dependencies.
Expand Down
2 changes: 2 additions & 0 deletions firebase-ml-modeldownloader/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Unreleased

- [changed] Bumped internal dependencies.

# 26.0.1

- [changed] Bumped internal dependencies.
Expand Down
2 changes: 2 additions & 0 deletions firebase-perf/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Unreleased

- [changed] Bumped internal dependencies.

# 22.0.4

- [fixed] Fixed StrictMode DiskReadViolation prompted by AppStartTrace setup. [#7340]
Expand Down
2 changes: 2 additions & 0 deletions firebase-sessions/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Unreleased

- [changed] Bumped internal dependencies.

# 3.0.4

- [fixed] Fixed a bug when the app foregrounds before Sessions has initialized (#7519)
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ browser = "1.3.0"
cardview = "1.0.0"
constraintlayout = "2.2.1"
coroutines = "1.9.0"
dagger = "2.51" # Don't bump above 2.51 as it causes a bug in AppDistro FeedbackSender JPEG code
dagger = "2.57.2"
datastore = "1.1.7"
dexmaker = "2.28.1"
dexmakerVersion = "1.2"
Expand Down
2 changes: 2 additions & 0 deletions transport/transport-runtime/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Unreleased

- [changed] Bumped internal dependencies.

# 4.1.0

- [feature] Support multiple encrypted experiment IDs.
Expand Down
Loading