-
Notifications
You must be signed in to change notification settings - Fork 14
Update license headers in test files to SPDX format #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Replaced existing Apache License 2.0 headers with SPDX identifiers in multiple test files. - Ensured consistent copyright attribution to FINOS FDC3 contributors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 75.93% 85.84% +9.90%
==========================================
Files 55 64 +9
Lines 453 565 +112
Branches 49 49
==========================================
+ Hits 344 485 +141
+ Misses 87 61 -26
+ Partials 22 19 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates license headers across the entire codebase, converting from verbose Apache License 2.0 headers to concise SPDX format identifiers, and changing copyright attribution from "Morgan Stanley" to "FINOS FDC3 contributors - see NOTICE file".
Key changes:
- Replaced 12-line Apache 2.0 license headers with 3-line SPDX format
- Updated copyright attribution to FINOS FDC3 contributors
- Applied changes consistently across test files, source files, examples, and configuration files
Reviewed changes
Copilot reviewed 169 out of 170 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Tests/Finos.Fdc3.Tests/*.cs | Updated license headers in all test files to SPDX format |
| src/Tests/Finos.Fdc3.SystemTextJson.Tests/*.cs | Updated license headers in System.Text.Json test files |
| src/Tests/Finos.Fdc3.NewtonsoftJson.Tests/*.cs | Updated license headers in Newtonsoft.Json test files |
| src/Tests/Finos.Fdc3.AppDirectory.Tests/*.cs | Updated license headers in AppDirectory test files |
| src/Fdc3/**/*.cs | Updated license headers in all core library source files |
| src/Fdc3.Json/**/*.cs | Updated license headers in JSON serialization library |
| src/Fdc3.NewtonsoftJson/**/*.cs | Updated license headers in Newtonsoft.Json library |
| src/Fdc3.AppDirectory/**/*.cs | Updated license headers in AppDirectory library |
| src/Examples/WpfFdc3/**/*.cs | Updated license headers in WPF example application |
| src/Examples/WpfFdc3/**/*.xaml | Updated license headers in XAML files |
| README.md | Removed old license header (with issue noted) |
| .gitignore | Removed inline license header comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE FINOS CORPORATE CONTRIBUTOR LICENSE AGREEMENT.
THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.