Add auto-create records feature, comment timestamp + cat: null fix #41
Open
Bierchermuesli wants to merge 2 commits intofiliparag:masterfrom
Open
Add auto-create records feature, comment timestamp + cat: null fix #41Bierchermuesli wants to merge 2 commits intofiliparag:masterfrom
Bierchermuesli wants to merge 2 commits intofiliparag:masterfrom
Conversation
filiparag
reviewed
Mar 26, 2026
| "request_timeout": Maximum duration of HTTP requests | ||
| "api_url": URL of the Hetzner Console'\''s API | ||
| "ip_url": URL of a service for retrieving external IP addresses | ||
| "auto_create_records": Automatically create missing DNS records (default: false) |
Owner
There was a problem hiding this comment.
While this is arguably nicer user experience-wise, I chose to go against it as adding the record manually is a kind of a double check that user's intention matches what the script's configuration does. It neither adds or deletes records, just updates them. If there is a mistake/typo in JSON config, it will not turn into a garbage record that needs to be removed using Hetzner's website.
I'm not sure which approach is better 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey - may I can add this feature and a small bug?
auto_create_records- creates missing DNS records instead of abortingcat: nullerror when onlyapi_keyis set and notapi_key_filein config