Redefine collection-level metadata and v0.3.0#39
Merged
Conversation
This was
linked to
issues
Aug 30, 2024
Contributor
Author
|
One example for FTW: fiboa/cli#92 |
3b2bd7e to
3053dcd
Compare
3053dcd to
8d5b796
Compare
This was
linked to
issues
Mar 10, 2025
Closed
d363307 to
f3db719
Compare
cholmes
approved these changes
Mar 10, 2025
Contributor
cholmes
left a comment
There was a problem hiding this comment.
Generally looks good, happy to approve and get this in and evolve as things go. But I do think it's likely now worth explaining a bit more what a 'collection' is conceptually, and explain a bit about merging, and things moving from collection to feature level, and potentially back up. I don't think this needs to be a ton, just enough for people to make sense of how to think about a collection and what properties to put there vs. not
…embers to FeatureCollection
Closed
Contributor
Author
|
Discussion results:
|
Contributor
Author
|
@cholmes Do you want to do your final review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #13 #40 #26 #34 #35 #36
Notes:
Proposed Changes:
PR Checklist:
or a CHANGELOG entry is not required.