Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
==========================================
+ Coverage 93.72% 93.83% +0.10%
==========================================
Files 18 18
Lines 1131 1151 +20
==========================================
+ Hits 1060 1080 +20
Misses 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
keiranjprice101
requested changes
Feb 26, 2026
Collaborator
keiranjprice101
left a comment
There was a problem hiding this comment.
Functionally good. But can you change the names of check_dir and check_file.
maybe find_tomo or similar.
I only ask because, right now in this moment, the context of check makes sense. But in 6 months, you would have to read the docstrings and code to work out what check_file actually means.
Member
Author
|
Made some changes, hopefully you are happy with them. |
keiranjprice101
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes None, fixes an issue in prod
Description
Go find the tomo folder instead of just the route of the experiment.