Skip to content

Actually find the tomo folder#481

Merged
keiranjprice101 merged 4 commits intomainfrom
add_tomo_folder_support_imat
Feb 26, 2026
Merged

Actually find the tomo folder#481
keiranjprice101 merged 4 commits intomainfrom
add_tomo_folder_support_imat

Conversation

@Pasarus
Copy link
Member

@Pasarus Pasarus commented Feb 26, 2026

Closes None, fixes an issue in prod

Description

Go find the tomo folder instead of just the route of the experiment.

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.83%. Comparing base (9896d2d) to head (ad5ebcc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
+ Coverage   93.72%   93.83%   +0.10%     
==========================================
  Files          18       18              
  Lines        1131     1151      +20     
==========================================
+ Hits         1060     1080      +20     
  Misses         71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@keiranjprice101 keiranjprice101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally good. But can you change the names of check_dir and check_file.

maybe find_tomo or similar.

I only ask because, right now in this moment, the context of check makes sense. But in 6 months, you would have to read the docstrings and code to work out what check_file actually means.

@Pasarus
Copy link
Member Author

Pasarus commented Feb 26, 2026

Made some changes, hopefully you are happy with them.

@keiranjprice101 keiranjprice101 merged commit 0f03509 into main Feb 26, 2026
9 checks passed
@keiranjprice101 keiranjprice101 deleted the add_tomo_folder_support_imat branch February 26, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants